Skip to content

Adding support for text/x-amp-html#16

Open
VictorAlmaraz wants to merge 1 commit intomuratgozel:masterfrom
VictorAlmaraz:master
Open

Adding support for text/x-amp-html#16
VictorAlmaraz wants to merge 1 commit intomuratgozel:masterfrom
VictorAlmaraz:master

Conversation

@VictorAlmaraz
Copy link
Copy Markdown

I'm currently working on a project that uses AMP4Email, which is an alternative MIME part and adds interactive capability in email messages.

I've added support for the text/x-amp-html MIME type, supporting it along with with plain text and HTML, that are also required to have AMP4Email working correctly.

I hope it can help others to deliver interactive e-mails using AMP4Email with MIMEText.

@galaxy79
Copy link
Copy Markdown

@muratgozel , any plans to add this support content type ?

@muratgozel
Copy link
Copy Markdown
Owner

I will look into this, thank you @VictorAlmaraz I have to test if it breaks anything related to other types.

@Manouchehri
Copy link
Copy Markdown

Same request here, any progress on this?

@Manouchehri
Copy link
Copy Markdown

@muratgozel Sorry to ping you, but while you're online, any chance of tackling this bug too? :)

@muratgozel
Copy link
Copy Markdown
Owner

@Manouchehri no problem :)) i'm doing a refactoring right now, reviewing the new specification and rewriting some things to align better with the spec. i intentionally left this request open will make sure there will be amp-html kind of support when i'm done with the changes.

@terryjbutler
Copy link
Copy Markdown

@muratgozel Hi there, great project!

I came across an issue trying to add a text/calendar part and I believe I hit the same sort of issue:

MIMETEXT_INVALID_MESSAGE_TYPE: Valid content types are text/html, text/plain but you specified "text/calendar".

There are two ways to add calendar parts, one as an attachment (all good), one as a part taking the following format:

--000000000000c3edcf062e6750ec
Content-Type: text/calendar; charset="UTF-8"; method=REPLY
Content-Transfer-Encoding: quoted-printable

BEGIN:VCALENDAR
<...>
END:VCALENDAR

--000000000000c3edcf062e6750ec--

Could a separate method to add arbitrary parts be worthwhile for these sorts of situations?

Hoping I haven't missed something very obvious :)

Many thanks in advance!
Terry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants