Skip to content

🐛 Complete QDMI child-device string conversions - #1952

Merged
burgholzer merged 2 commits into
mainfrom
agent/extract-1912-independent
Jul 29, 2026
Merged

🐛 Complete QDMI child-device string conversions#1952
burgholzer merged 2 commits into
mainfrom
agent/extract-1912-independent

Conversation

@burgholzer

@burgholzer burgholzer commented Jul 27, 2026

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

Description

Complete the public qdmi::toString mappings for the child-device session parameter and device property introduced with child-device support. This keeps diagnostics and property-name formatting exhaustive for the current QDMI enum surface.

This small fix was identified while reviewing #1912 and is extracted because it has no dependency on configurable device discovery. The existing child-device changelog entry now also attributes this follow-up to #1952 and retains the original human author attribution.

Validation

  • Focused child-device string-conversion tests: 2 passed
  • Complete FoMaC C++ test binary: 171 passed
  • uvx nox -s lint
  • git diff --check

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the changed functionality.
  • Documentation and migration guidance are not needed for this diagnostic-string completion.
  • The existing changelog entry includes this PR and all human authors.
  • The change follows the project's style guidelines and introduces no new warnings.
  • The changes are fully tested and pass the relevant local checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • AI-assisted commits include an Assisted-by: [Model Name] via [Tool Name] footer.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

Assisted-by: GPT-5.6-sol via Codex
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Assisted-by: gpt-5.6-sol via Codex
@burgholzer burgholzer added enhancement Improvement of existing feature c++ Anything related to C++ code QDMI Anything related to QDMI labels Jul 27, 2026
@burgholzer burgholzer added this to the QDMI Support milestone Jul 27, 2026
@burgholzer
burgholzer marked this pull request as ready for review July 27, 2026 17:50
@burgholzer
burgholzer enabled auto-merge (squash) July 27, 2026 17:50
@burgholzer burgholzer added fix Fix for something that isn't working and removed enhancement Improvement of existing feature labels Jul 27, 2026
@burgholzer burgholzer self-assigned this Jul 27, 2026
@burgholzer
burgholzer merged commit 537a694 into main Jul 29, 2026
33 checks passed
@burgholzer
burgholzer deleted the agent/extract-1912-independent branch July 29, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code fix Fix for something that isn't working QDMI Anything related to QDMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant