Ignore RUSTSEC-2021-0145#4164
Merged
Merged
Conversation
pinkisemils
approved these changes
Nov 24, 2022
Collaborator
pinkisemils
left a comment
pinkisemils
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
The vulnerability affects custom global allocators on Windows, so we can safely ignore it
dlon
force-pushed
the
ignore-atty-vuln
branch
from
14bc2a7 to
bcb4d1d
Compare
|
clap has had a release that fixed this by switching to is-terminal also I see env_logger has had a release as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This vulnerability in
atty(https://rustsec.org/advisories/RUSTSEC-2021-0145) only affects custom global allocators on Windows, so we can ignore it for now.attyis a dependency due toclapandenv_logger. Stop ignoring the issue once they've moved away from using it:clap-rs/clap#4249
rust-cli/env_logger#246
This change is