Update codeserver#241
Open
mtchoum1 wants to merge 18 commits into
Open
Conversation
Pin the hermetic prefetch submodule to coder/code-server v4.127.0 (VS Code 1.127.0) as the first step of the 4.127 upgrade. Co-authored-by: Cursor <cursoragent@cursor.com>
Switch nodejs module stream from 22 to 24 in rpms.in.yaml and Dockerfile, pin CODESERVER_VERSION to v4.127.0, rename the patch overlay directory, and regenerate ODH rpms.lock.yaml (nodejs 24.18.0). RHDS rpms.lock.yaml still needs regeneration on a subscribed RHEL 9.6+ host. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace stale 4.106 lockfile overlays with minimal 1.127 deltas: es5-ext override, emmet registry css-parser, gulpfile.reh.ts ppc64/s390x targets, and merged build-vscode.sh for copilot/core-ci gulp tasks. Drop redundant remote, extensions, test, and microsoft-authentication overlays now covered upstream. Co-authored-by: Cursor <cursoragent@cursor.com>
VS Code 1.127 renamed mermaid-chat-features to mermaid-markdown-features; update Tekton npm prefetch paths so Hermeto resolves the correct lockfile. Co-authored-by: Cursor <cursoragent@cursor.com>
Align utils/ and setup-offline-binaries.sh with product.json builtInExtensions pins. Python 2026.0.0 and Jupyter 2025.9.1 remain compatible (^1.95 / ^1.105). Co-authored-by: Cursor <cursoragent@cursor.com>
apply-patch.sh must not rewrite @vscode/ripgrep-universal (prebuilt multi-arch); only legacy @vscode/ripgrep tarballs need the postinstall override. Patching universal corrupted the cachi2 cache and broke npm ci. Co-authored-by: Cursor <cursoragent@cursor.com>
Bump tree-sitter binding.gyp to c++20 when using system nodejs-devel headers and align build/.npmrc target with remote (24.15.0) for VS Code 1.127. Co-authored-by: Cursor <cursoragent@cursor.com>
npm:rolldown-vite@latest cannot resolve offline; pin 7.3.1 and rollup 4.59.0 in the v4.127.0 patch overlay to match the lockfile. Co-authored-by: Cursor <cursoragent@cursor.com>
Set the recommended (N) tag notebook-software annotation to match the v4.127.0 upgrade on the 3.5 release stream for ODH and RHOAI manifests. Co-authored-by: Cursor <cursoragent@cursor.com>
VS Code 1.127 ships build/lib as .ts sources; GHA apply-patch failed when tweak-gha.sh still targeted the old compiled .js paths. Co-authored-by: Cursor <cursoragent@cursor.com>
Writing the key into the repo root left an untracked file and caused git-crypt unlock to fail with "Working directory not clean" in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
Five .vsix files were committed as raw blobs while .gitattributes marks *.vsix as LFS. GitHub runners with Git LFS then left the tree dirty and blocked git-crypt unlock in RHDS workflows. Also skip LFS smudge on checkout and normalize the tree before unlock.
Subscription-manager registration during podman build is inactive when the lockfile container runs, leaving CDN repos unavailable and causing DNF "No match" errors for base packages like gcc and perl. Co-authored-by: Cursor <cursoragent@cursor.com>
The build:vscode step runs git checkout in lib/vscode, which requires git-lfs hooks. git-lfs was only installed in the final codeserver stage. Co-authored-by: Cursor <cursoragent@cursor.com>
Serialize and slim core-ci for GHA (reh-web esbuild only, skip typecheck, mangler/transpiler workers capped at 1). Split build:vscode into separate Dockerfile RUN steps so each gulp phase gets a fresh process tree. Co-authored-by: Cursor <cursoragent@cursor.com>
Upstream code-server 4.127 dropped the release:standalone npm script. Re-add build-standalone-release.sh as a hermetic patch overlay and invoke it directly from the Dockerfile after npm run release. Co-authored-by: Cursor <cursoragent@cursor.com>
Hermetic builds already bundle production node_modules via build-release.sh; re-running npm install triggers postinstall.sh's node v22 check and fails on ODH nodejs:24. Co-authored-by: Cursor <cursoragent@cursor.com>
Waive Node.js 24 DEP0169 startup noise in the airgapped log test and add check-payload ErrNotDynLinked exceptions for VS Code 1.127 Copilot binaries. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
/build-konflux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: