Feature: add sorting by downtime duration and type#32
Open
abhishekmagdum wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds two new controls to the Incident timeline panel: a sort dropdown (date / duration desc / duration asc) and a row of impact-type filter pills (Major, Minor, Maintenance, Operational) that can be combined freely.
Changes:
- New
<select id="timelineSort">and.timeline-filtersmarkup added to the Incident timeline panel header. render()inapp.jsreworked sorenderTimelinerecomputes filtered/sorted slices on every change; date-desc keeps the original grouped layout, duration sorts flatten into a ranked list capped at 20.- New CSS for
.timeline-filters,.filter-pill*, and.sort-selectstyling, including pressed/unpressed pill opacity and a custom dropdown chevron.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| site/index.html | Adds the sort <select> to panel actions and a row of filter pill buttons. |
| site/app.js | Implements filter set, sort order state, and the new dual-path rendering inside renderTimeline, plus event listeners for sort/filter controls. |
| site/styles.css | Adds styling for the timeline filter pills, the divider above them, and the custom sort select. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the ability to sort by the longest/shortest downtime events in Github history. Can also sort by the disruption type (critical, major, minor, maintenance, or operational).
Motivation
Out of curiosity, I wanted to see what events caused the largest disruptions in Github downtime history, since it's genuinely interesting to read the post-mortem reports that are usually included.
Screenshots
Changes
autocomplete="off" on the sort select prevents browser form-state persistence across page refreshes