Skip to content

Migrate SubjectMap#onError to take a Throwable #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamsp wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Open

Migrate SubjectMap#onError to take a Throwable #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c02457
Migrate SubjectMap#onError to take a Throwable
Aug 11, 2017
799b4c7
Version bump to 0.2.3
Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencies {
allprojects {
sourceCompatibility = 1.7
targetCompatibility = 1.7
version = '0.2.2'
version = '0.2.3'
}

jacocoTestReport {
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/github/mproberts/rxtools/SubjectMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,15 +230,15 @@ public void call(Subject<V, V> subject)
* to get will return a new observable and attempt to fault the value in
*
* @param key key with which the specified value is to be associated
* @param exception exception to be sent to the specified observable
* @param throwable throwable to be sent to the specified observable
*/
public void onError(K key, final Exception exception)
public void onError(K key, final Throwable throwable)
{
emitUpdate(key, new Action1<Subject<V, V>>() {
@Override
public void call(Subject<V, V> subject)
{
subject.onError(exception);
subject.onError(throwable);
}
}, true);
}
Expand Down