Fix several instances of PulseAudio API misuse#103
Open
Conversation
padenot
requested changes
Mar 17, 2026
Collaborator
padenot
left a comment
There was a problem hiding this comment.
A question on the locks, the rest looks fine.
05ac9fc to
a15b5d8
Compare
kinetiknz
commented
Mar 17, 2026
| stm.context.mainloop.unlock(); | ||
|
|
||
| if !r { | ||
| drop(mainloop_lock.take()); |
Contributor
Author
There was a problem hiding this comment.
This also fixes the case where we unlocked the mainloop lock too early if we entered the log_enabled() path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.