Bug 2066252 - Prevent save if keyword checkin-needed-tb exists without target milestone - #2734
Conversation
…t target milestone
There was a problem hiding this comment.
🟡 Changes recommended
Product-only moves can bypass the new validation and introduce the prohibited state.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds validation requiring a target milestone when checkin-needed-tb is used for Thunderbird-related products.
Changes:
- Adds create/update milestone validation.
- Registers the validator and adds its user-facing error.
File summaries
| File | Description |
|---|---|
CheckinNeededTbMilestone.pm |
Implements validation. |
Extension.pm |
Registers the validator. |
user-error-errors.html.tmpl |
Adds the validation error. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| return if !$bug->has_keyword(KEYWORD); | ||
|
|
||
| # The product's default milestone (normally '---') means 'not set'. | ||
| return if $bug->target_milestone ne $product->default_milestone; |
There was a problem hiding this comment.
Should we compare with --- directly? Is there any risk in a silent pass if a product gets a real default milestone?
There was a problem hiding this comment.
I am not sure what silent pass means if it gets a real milestone. The products default milestone can be set to any valid milestone value and is what gets set if a user doesn't set anything for milestone.
No description provided.