Repository navigation
feat(fx-api): add request duration histogram - #6875
Draft
GregHilstonMozilla wants to merge 2 commits into
Draft
GregHilstonMozilla wants to merge 2 commits into
GregHilstonMozilla wants to merge 2 commits into
Conversation
Time every Firefox API request in withFxaUser, auth and rate limit included, as firefox_api_request_duration_seconds, labelled by endpoint and status_code.
gate catches every error itself, so the outer try/finally and its 500 default never ran.
2 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-5347
Description
Adds
firefox_api_request_duration_seconds, a histogram timing every request to the Firefox API endpoints in openapi.yml. It's recorded inwithFxaUser, so auth failures (401) and rate limited requests (429) are timed too, not just the handler.Historically, I had some downtime, so some work from the ticket already landed in #6862, #6869, #6873 and #6874.
Observability
Latency panels (p50/p95/p99 by endpoint) and alerts are coming in later via MNTOR-5348.
How to test
Checklist (Definition of Done)