Skip to content

test(notify): check the built server publishes to Pub/Sub - #6868

Draft
groovecoder wants to merge 1 commit into
mainfrom
mntor-pubsub-built-server-test
Draft

groovecoder wants to merge 1 commit into
mainfrom
mntor-pubsub-built-server-test

Conversation

@groovecoder

Copy link
Copy Markdown
Member

References:

Jira: MNTOR-5314

Description

Unit tests load gRPC from node_modules. Production runs the code that next build emits. A protobufjs bump broke only the built code, and breach alerts stopped for seven weeks (IIM-306, MNTOR-5314).

This test runs next start against the Pub/Sub emulator in CI. It fails on the May build that shipped the bug. It passes on the build before it. It needs no secrets, so Dependabot PRs run it too.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

Unit tests load gRPC from node_modules. Production runs the code
that next build emits. A protobufjs bump broke only the built code,
and breach alerts stopped for seven weeks (IIM-306, MNTOR-5314).

This test runs next start against the Pub/Sub emulator in CI. It
fails on the May build that shipped the bug. It passes on the build
before it. It needs no secrets, so Dependabot PRs run it too.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant