Repository navigation
test(notify): check the built server publishes to Pub/Sub - #6868
Draft
groovecoder wants to merge 1 commit into
Draft
groovecoder wants to merge 1 commit into
groovecoder wants to merge 1 commit into
Conversation
Unit tests load gRPC from node_modules. Production runs the code that next build emits. A protobufjs bump broke only the built code, and breach alerts stopped for seven weeks (IIM-306, MNTOR-5314). This test runs next start against the Pub/Sub emulator in CI. It fails on the May build that shipped the bug. It passes on the build before it. It needs no secrets, so Dependabot PRs run it too.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-5314
Description
Unit tests load gRPC from node_modules. Production runs the code that next build emits. A protobufjs bump broke only the built code, and breach alerts stopped for seven weeks (IIM-306, MNTOR-5314).
This test runs next start against the Pub/Sub emulator in CI. It fails on the May build that shipped the bug. It passes on the build before it. It needs no secrets, so Dependabot PRs run it too.
How to test
Checklist (Definition of Done)