Skip to content

Drop MitreCVE table via migration#17143

Open
janriokrause wants to merge 2 commits intomainfrom
janriokrause/remove-cve-feed-migration
Open

Drop MitreCVE table via migration#17143
janriokrause wants to merge 2 commits intomainfrom
janriokrause/remove-cve-feed-migration

Conversation

@janriokrause
Copy link
Copy Markdown
Contributor

As a follow-up from PR #17142, delete the MitreCVE table via a migration.

Closes issue #16519.

@janriokrause janriokrause self-assigned this Apr 21, 2026
@janriokrause janriokrause requested a review from a team as a code owner April 21, 2026 13:38
@janriokrause janriokrause force-pushed the janriokrause/remove-cve-feed-migration branch from 07836d3 to 13cb78d Compare April 21, 2026 14:14
@janriokrause
Copy link
Copy Markdown
Contributor Author

Due to failing tests, the deletion of the MitreCVE model and the dropping of its table will be included in a single commit.

@janriokrause janriokrause linked an issue Apr 21, 2026 that may be closed by this pull request
1 task
@janriokrause janriokrause force-pushed the janriokrause/remove-cve-feed-migration branch from 13cb78d to 93f59e4 Compare April 21, 2026 14:29
@janriokrause janriokrause requested a review from a team as a code owner April 21, 2026 14:29
@janriokrause janriokrause changed the base branch from main to janriokrause/remove-cve-feed April 21, 2026 14:30
@janriokrause janriokrause force-pushed the janriokrause/remove-cve-feed-migration branch from 93f59e4 to f0654cc Compare April 21, 2026 14:31
@janriokrause
Copy link
Copy Markdown
Contributor Author

Rebased on top of PR #17142. Sorry for the mess.

@janriokrause janriokrause removed the request for review from a team April 21, 2026 14:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.02%. Comparing base (674b6d8) to head (bcc93ac).

Additional details and impacted files
@@                       Coverage Diff                        @@
##           janriokrause/remove-cve-feed   #17143      +/-   ##
================================================================
+ Coverage                         81.78%   82.02%   +0.24%     
================================================================
  Files                               175      175              
  Lines                              9376     9325      -51     
================================================================
- Hits                               7668     7649      -19     
+ Misses                             1708     1676      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

R+

Let's wait till the target PR is merged and deployed before we merge this one. Adding the Do Not Merge label now

@stevejalim stevejalim force-pushed the janriokrause/remove-cve-feed branch from b5dd53b to cf021b7 Compare April 22, 2026 09:41
@janriokrause janriokrause force-pushed the janriokrause/remove-cve-feed-migration branch from f0654cc to 4ec6a98 Compare April 24, 2026 17:10
@janriokrause janriokrause force-pushed the janriokrause/remove-cve-feed branch from cf021b7 to 28decf9 Compare April 24, 2026 17:10
The `cve-feed.json` endpoint was already removed and redirected to
410 Gone in #16542. This removes the remaining Python backend: the
`mitre_cve_feed` view, the `add_or_update_cve` management command
logic, and all associated tests.

A migration to drop the `MitreCVE` model and database table will be
in a separate commit.
@janriokrause janriokrause force-pushed the janriokrause/remove-cve-feed branch from 28decf9 to 674b6d8 Compare April 24, 2026 17:18
@janriokrause janriokrause force-pushed the janriokrause/remove-cve-feed-migration branch from 4ec6a98 to bcc93ac Compare April 24, 2026 17:18
@janriokrause
Copy link
Copy Markdown
Contributor Author

Also removed MitreCVE from export-db-to-sqlite.sh as mentioned in PR #17142.

Base automatically changed from janriokrause/remove-cve-feed to main April 28, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove cve-feed.json

2 participants