Skip to content

Update GitHub Actions workflow, PHP requirement in dev-setup.sh - #1056

Merged
flodolo merged 1 commit into
mainfrom
tests_gh_action_update
Oct 26, 2026
Merged

flodolo merged 1 commit into
mainfrom
tests_gh_action_update

Conversation

@pascalchevrel

Copy link
Copy Markdown
Member
  • Update actions (setup-php now runs on Node 24)
  • Fix Composer cache key, composer.lock is not tracked
  • Use Node 24 for ESLint
  • Remove unused global php-cs-fixer install
  • Restrict token permissions, don't persist credentials on checkout
  • Move config file creation to a dedicated step
  • Update minimum PHP version mentioned in dev-setup.sh

* Update actions (setup-php now runs on Node 24)
* Fix Composer cache key, composer.lock is not tracked
* Use Node 24 for ESLint
* Remove unused global php-cs-fixer install
* Restrict token permissions, don't persist credentials on checkout
* Move config file creation to a dedicated step
* Update minimum PHP version mentioned in dev-setup.sh

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pascalchevrel
pascalchevrel requested a review from flodolo October 26, 2026 12:44
@pascalchevrel

Copy link
Copy Markdown
Member Author

This restricts CI to php 8.4 and up and fixes some minor issues. I don't know what version you have on transvision.flod.org, we can add back an older version if needed.

@flodolo flodolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My server is running 8.5 (Ubuntu 26 LTS), so we're good.

@flodolo
flodolo merged commit f731f64 into main Oct 26, 2026
2 checks passed
@flodolo
flodolo deleted the tests_gh_action_update branch October 26, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants