Fix 'Could not find matching constructor' while change password for users

[dixitdeepak]

SimpleAuthenticationInfo expects a ByteSource as its salt argument. Passing an empty string for accounts without a password salt caused Groovy to resolve an invalid String, String, String, String constructor.

This matches the pattern used by MoquiShiroRealm.getAuthenticationInfo and applies to both current-password and reset-password verification.

[dixitdeepak]

Attached error for reference

Error running service org.moqui.impl.UserServices.update#Password (Throwable) Artifact stack: org.moqui.impl.UserServices.update#Password,........... groovy.lang.GroovyRuntimeException: Could not find matching constructor for: org.apache.shiro.authc.SimpleAuthenticationInfo(String, String, String, String) at org_moqui_impl_UserServices_update_Password.run(org_moqui_impl_UserServices_update_Password:79) at org.moqui.impl.actions.XmlAction.run(XmlAction.java:67) at org.moqui.impl.service.runner.InlineServiceRunner.runService(InlineServiceRunner.java:59) at org.moqui.impl.service.ServiceCallSyncImpl.callSingle(ServiceCallSyncImpl.java:322) at org.moqui.impl.service.ServiceCallSyncImpl.call(ServiceCallSyncImpl.java:125) at screen_webroot_Login_xml_transition_changePassword_service_call.run(screen_webroot_Login_xml_transition_changePassword_service_call:9) at org.moqui.impl.actions.XmlAction.run(XmlAction.java:67) at org.moqui.impl.screen.ScreenDefinition$TransitionItem.run(ScreenDefinition.groovy:982) at org.moqui.impl.screen.ScreenRenderImpl.recursiveRunTransition(ScreenRenderImpl.groovy:749) at org.moqui.impl.screen.ScreenRenderImpl.recursiveRunTransition(ScreenRenderImpl.groovy:745) at org.moqui.impl.screen.ScreenRenderImpl.internalRender(ScreenRenderImpl.groovy:457) at org.moqui.impl.screen.ScreenRenderImpl.render(ScreenRenderImpl.groovy:173) at org.moqui.impl.webapp.MoquiServlet.service(MoquiServlet.groovy:118) at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:723) at org.moqui.impl.webapp.ElasticRequestLogFilter.doFilter(ElasticRequestLogFilter.groovy:96) at java.base/java.lang.Thread.run(Thread.java:1583)