Addition of true difference detection for Famix-Simpl-Diff#15
Open
AntoninGoslin wants to merge 24 commits intomoosetechnology:differences-listfrom
Conversation
…xpected: ' ' | Actual: 'private int something' | On Class1)
Adding getter and adapted initilize
…ces between the two models, and not just a boolean. Need to add some tests now
…ist of one difference with the entityChanged reason
…e with the 'propertyChanged' reason
…ame methods or not. Used for TDD, not working for the moment
…ve a list of all the differences that represent deletion
…ve a list of all the differences that represent addition
…el, else we have a root entity set to null
…se. Tests are now ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A FamixDiff class has been added to the Famix-Simpl-Diff package.
Famix-Simpl-Diff now includes a list of the differences it will record whilst traversing the entities.
We have different type of differences:
I mainly changed the methods compareRelation: from: to: and compareEntity: to: in order to implement the differences logic
We need to fix some issues relating to the way we check for additions and removals. Some tests depend on the order in which we iterate through the lists of entities, and it's not normal.
We will also need to change the way we return informations. At the moment, we only return a boolean value, without the actual list of concrete differences.