Repository navigation
test(cmd): add Firefox and Safari extract goldens - #658
Merged
Merged
Conversation
Phase 6 moves the Firefox and Safari parsers, so today's output is locked first, as the Chromium goldens were before Phase 5.
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6, step 1 of 4 (RFC-012): lock today's Firefox and Safari output before their parsers move.
What
t.TempDir()like the Chromium one:key4.db, plus the non-profile entries a Linux profiles dir holds (profiles.ini,Crash Reports). Every category Firefox exports has records.~/Librarytree with the default profile and a titled and an untitled named profile fromSafariTabs.db, the sharedDownloads.plist, the container and legacy cookie jars, WebKit origin stores (first-party, partitioned, and one without localStorage), and both extension plists.extract-firefox-{csv,json,cookie-editor}andextract-safari-{csv,json,cookie-editor}. As for Chromium, the cookie-editor golden holds onlycookie.json.folderalwaysurl,typeempty,id0; Safari IDs repeat per folder). Step 4 fixes them as a listed golden diff.HOMEat the fixture, so no real login keychain is read and Safari exports no passwords here.TestExtractGolden,TestPipelineGolden, and the two new tests share one per-format golden loop. The file and SQLite helpers move from the Chromium fixture tofixture_test.go.Test-only: no production code changes, and the existing goldens are unchanged.
Tests
go test ./...andgolangci-lint runpass locally;GOOS=linuxandGOOS=windowsvet pass.-count=5).