Skip to content

Feat/check and ship #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazeburo merged 2 commits into from
Aug 16, 2026
+9 −5
Merged

Feat/check and ship #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c20dd68
fix: set default checker name if not provided
kazeburo Aug 16, 2026
69aed7b
fix: update expected output format in TestInternalChecker
kazeburo Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions flagrun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"fmt"
"io"
"os"
"path/filepath"
"reflect"
"runtime"
"runtime/debug"
Expand Down Expand Up @@ -211,15 +212,18 @@ func (f *Flagrun) internalChecker(
if chk == nil {
return "UNKNOWN: checker returned nil", UNKNOWN
}
if chk.Name == "" {
chk.Name = filepath.Base(os.Args[0])
}
switch chk.Status {
case checkers.OK:
return chk.String(), OK
return chk.String(), OK
case checkers.WARNING:
return chk.String(), WARNING
return chk.String(), WARNING
case checkers.CRITICAL:
return chk.String(), CRITICAL
return chk.String(), CRITICAL
default:
return chk.String(), UNKNOWN
return chk.String(), UNKNOWN
}
}

Expand Down
2 changes: 1 addition & 1 deletion flagrun_check_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func TestInternalChecker(t *testing.T) {
stdoutStr := stdout.String()

assert.Equal(t, "", stdoutStr)
assert.Equal(t, tt.wantStdout, msg)
assert.Equal(t, "flagrun.test"+tt.wantStdout, msg)
assert.Equal(t, tt.wantCode, code)
})
}
Expand Down