feat: add Checker and Shipper interfaces, update README, and implement tests - #12
Merged
Conversation
Contributor
PR Reviewer Guide 🔍(Review updated until commit 9217c3b)Here are some key observations to aid the review process:
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
Persistent review updated to latest commit 763d846 |
Contributor
|
Persistent review updated to latest commit a1efaf4 |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
Persistent review updated to latest commit d6d0b1e |
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Contributor
|
Persistent review updated to latest commit 9217c3b |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Type
Enhancement, Tests, Documentation
Description
Add
CheckerandShipperexecution modesGenericize
Runner[T]message handlingShare flag parsing and configuration construction
Document APIs and test all modes
Diagram Walkthrough
File Walkthrough
flagrun.go
Add generic runner, checker, and shipper APIsflagrun.go
Runnergeneric throughRunner[T].CheckerandShipperinterfaces withCheckandShipentry points.Flagrunsetup and command-line argument parsing.checkers.Checkerstatuses to plugin exit codes and handle nilresults.
flagrun_check_test.go
Test checker execution and status mappingflagrun_check_test.go
Checkbehavior.flagrun_go_test.go
Update generic runner execution testsflagrun_go_test.go
internalGosetup.flagrun_shipper_test.go
Test shipper execution and CLI handlingflagrun_shipper_test.go
ShipreturnsOK.README.md
Document runner checker and shipper usageREADME.md
Runner[T],Checker, andShipperinterfaces.CheckandShip.go.mod
Add Mackerel checker dependencygo.mod
github.com/mackerelio/checkersdependency.