Repository navigation
fixing ci failures - #578
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The workaround’s archive extraction and Node installation need Windows x64/ARM64 CI verification, since the tests cover only PATH filtering and those environments were unavailable for review.
No open issues 🎉
What changed in this PR
This PR addresses Kingfisher SDK CI failures by hardening Maturin downloads and working around Node archive extraction crashes on Windows ARM64.
Changes:
- Add HTTP-error handling, bounded retries, and timeouts for Maturin downloads in manylinux containers.
- Route Node build and verification installs through a wrapper that selects Windows PowerShell for ARM64 archive extraction.
- Add regression tests for download behavior, workflow wiring, and Windows PATH filtering.
| File | Description |
|---|---|
scripts/tests/test_python_sdk_release.py |
Tests Maturin download retries, HTTP failures, and timeout configuration. |
scripts/tests/test_node_sdk_release.py |
Tests wrapper usage and Windows archive-selector PATH handling. |
.github/workflows/python-sdk.yml |
Applies the curl configuration inside manylinux containers. |
.github/workflows/node-sdk.yml |
Uses the Node setup wrapper and runs Windows selector tests. |
.github/maturin-curl/.curlrc |
Defines download failure handling, retries, and timeouts. |
.github/actions/setup-node/action.yml |
Adds a scoped Windows ARM64 extraction workaround around pinned setup-node. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.