Repository navigation
Keep the default Pages deploy timeout - #576
Merged
Merged
Conversation
actions/deploy-pages rejects timeouts above 600000 ms and clamps them back to the default, which only adds a warning to every run. Leave the documented maximum in place and note that a stalled Pages deployment has to be re-run.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are blocking the GitHub Pages deployment timeout update.
No open issues 🎉
What changed in this PR
Restores the default GitHub Pages deployment timeout, removing the unsupported override introduced in #575 while preserving the ubuntu-24.04 runner pin.
Changes:
- Removes the 20-minute timeout override that caused warnings.
- Adds a comment documenting the 10-minute cap and the need to rerun stalled deployments.
| File | Description |
|---|---|
.github/workflows/docs.yml |
Removes the timeout override and documents the deployment limit. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/deploy-pagesrejects anytimeoutabove 600000 ms and clamps it back to the 10 minute default, so the input added in #575 only produced a warning on every run. Remove it and document the cap instead: a Pages deployment that stalls inupdating_pageshas to be re-run, not waited out.The
ubuntu-24.04pin in this workflow stays, which is what removed the Ubuntu 26 migration warning.