Add Authentication Required and Proxy Authentication Required.#107
Open
ssether-usinternet wants to merge 24 commits intomojolingo:developfrom
Open
Add Authentication Required and Proxy Authentication Required.#107ssether-usinternet wants to merge 24 commits intomojolingo:developfrom
ssether-usinternet wants to merge 24 commits intomojolingo:developfrom
Conversation
Member
|
@Karn Wanted to bring this PR to your attention. Someone else in the community opened it. Are you willing to have us merge this back into the main SippyCup repo? |
Member
|
@Karn Would you let us know if you are willing to have your work merged into the upstream Sippy Cup code base? |
|
Hey @bklang, apologies for the late reply. We can totally look at merging this back upstream, give me a few days to clean up the code and get it into a reviewing state! |
933d72f to
3ae18f5
Compare
2d0a579 to
3521f03
Compare
Adding 400 SIP message
Parameterizing sendrecv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this fork of Sippy Cup that adds these two very useful features. Authentation and Proxy Auth are difficult enough in sipp that (previously) I just gave up and didn't require authentication in my test infrastructure. This addition makes the auth effortless.
Auth becomes as simple as:
Proxy auth would mean using
s.proxy_auth_requiredinstead of
s.auth_requiredThis isn't my code, and I don't know why a pull request was ever created for this, but the only real potential problem as I see it is the method signature for adding a header is now an array, not a string to allow for multiple headers. If necessary to accept this merge request, it could be removed. The following commit is where it was added:
Enflick@6ae9db5