Conversation
There was a problem hiding this comment.
The tricky thing here is that the moderator does not necessarily need to be in the room at the time that she kicks another user who is.
@bklang How much do we care to deal with this edge case?
There was a problem hiding this comment.
Hah, there's also a bug here, it should read: Candy.Core.getRoster().get(actor);. :)
Could be as simple as checking to see if the actor exists? I generally feel like fixing edge case bugs helps prevent strange/tricky bugs in the future.
There was a problem hiding this comment.
If it doesn't exist in our roster, we'd have to do similarly to elsewhere and allocate a temporary object. We should extract this somewhere common.
There was a problem hiding this comment.
Is new Candy.Core.Contact not common enough? Where would you stick something like this?
I'm wondering if it makes sense to continue sending potentially undefined variables here (
reasonandactor), or it we should consider something like this:Kick/ban:
Leave: