Skip to content

[WIP] candy:core.presence.room triggerHandler #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malakada wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

[WIP] candy:core.presence.room triggerHandler #5

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ed5d23
Removed roomJid and roomName in favor of finding the room object and …
Jan 7, 2015
54bb84b
We have already created the room variable.
Jan 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/core/event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,20 +625,21 @@ Candy.Core.Event = (function(self, Strophe, $) {
}
}
}

var room = Candy.Core.getRoom(roomJid);
Copy link
Copy Markdown
Member

@benlangfeld benlangfeld Jan 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

room was already assigned above - I don't think this assignment is necessary.


/** Event: candy:core.presence.room
* Room presence updates
*
* Parameters:
* (String) roomJid - Room JID
* (String) roomName - Room name
* (Candy.Core.Chatroom) room - The room object
* (Candy.Core.ChatUser) user - User which does the presence update
* (String) action - Action [kick, ban, leave, join]
* (Candy.Core.ChatUser) currentUser - Current local user
* (Boolean) isNewRoom - Whether the room is new (has just been created)
*/
$(Candy).triggerHandler('candy:core.presence.room', {
'roomJid': roomJid,
'roomName': room.getName(),
'room': room,
'user': user,
'action': action,
'currentUser': currentUser,
Expand Down