Deprecate the legacy HTTP+SSE transport - #3204
Open
maxisbey wants to merge 1 commit into
Open
Claude / Claude Code Review
completed
Jul 28, 2026 in 20m 33s
Code review found 3 potential issues
Found 1 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/mcp/server/mcpserver/server.py:361-369 |
run(transport="sse") runtime warning names run_sse_async, not the API the caller used |
Annotations
Check warning on line 369 in src/mcp/server/mcpserver/server.py
claude / Claude Code Review
run(transport="sse") runtime warning names run_sse_async, not the API the caller used
🟡 The `@deprecated` decorator on the `run(transport="sse")` overload has no runtime effect (PEP 702: a decorated `@overload` stub only informs static checkers), so at runtime a `mcp.run(transport="sse")` caller instead sees the nested `run_sse_async` warning — "Use `run_streamable_http_async` instead" — naming an async API they never called, when the direct migration is `transport="streamable-http"` in the same `run()` call. Fix by `warnings.warn()`-ing the overload's transport-oriented message
Loading