Make the per-version wire packages private (mcp_types._v*) - #3191
Merged
Claude / Claude Code Review
completed
Jul 27, 2026 in 18m 58s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | scripts/gen_surface_types.py:274 |
schema/README.md still references the old mcp_types/v output path |
Annotations
Check warning on line 274 in scripts/gen_surface_types.py
claude / Claude Code Review
schema/README.md still references the old mcp_types/v<version> output path
schema/README.md line 6 still documents the generator output as `src/mcp-types/mcp_types/v<version>/__init__.py`, but this PR renames the generated packages to `_v<version>`, so the README now points at a path that no longer exists. Update it to `src/mcp-types/mcp_types/_v<version>/__init__.py` to match the other references this PR already fixed (docs/migration.md, the generator docstring, etc.).
Loading