Align with spec #3002: optional clientInfo, serverInfo in result _meta - #3143
Merged
Claude / Claude Code Review
completed
Jul 22, 2026 in 21m 49s
Code review found 2 potential issues
Found 3 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | docs/whats-new.md:200 |
docs/whats-new.md still claims client.server_info is unconditionally populated after connect |
Annotations
Check warning on line 200 in docs/whats-new.md
claude / Claude Code Review
docs/whats-new.md still claims client.server_info is unconditionally populated after connect
docs/whats-new.md line 47 still says `client.server_info`, `client.server_capabilities`, and `client.protocol_version` "are simply there afterwards", but this PR makes `Client.server_info` `Implementation | None` (anonymous 2026-era servers and bare version pins read as `None`), contradicting the new bullet this PR adds at line 200 of the same file. Soften line 47 the way the docs/client/index.md recap was softened, e.g. "`server_capabilities` and `protocol_version` are simply there afterwards;
Loading