Fix memory leak#32
Open
messmerd wants to merge 1 commit into
Open
Conversation
Author
|
It looks like this issue is present upstream, so I just contacted Tim at http://quitte.de/dsp/caps.html#Contact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In interface.cc, an array of Descriptor objects is dynamically created and then later destroyed by calling delete on pointers to the base class DescriptorStub. However, since DescriptorStub's destructor is non-virtual, the destructors of derived classes are not called and this causes a memory leak which I detected with AddressSanitizer:
This PR fixes the problem by making DescriptorStub's destructor virtual.