Skip to content

6.5 Fixes#392

Open
nnra6864 wants to merge 4 commits intomob-sakai:mainfrom
nnra6864:6.5-fixes
Open

6.5 Fixes#392
nnra6864 wants to merge 4 commits intomob-sakai:mainfrom
nnra6864:6.5-fixes

Conversation

@nnra6864
Copy link
Copy Markdown

Description

Unity 6.5 introduces many breaking changes related to EntityId, read more about it here:
https://discussions.unity.com/t/planned-breaking-changes-in-unity-6-5-updated-2026-03-27/1694205

I am honestly just trying to help with porting the asset to make the transition as painless as possible and make it usable in newer unity versions.

Type of change

Please write the commit message in the format corresponding to the change type.
Please see Conventional Commits for more information.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update documentations
  • Others (refactoring, style changes, etc.)

Test environment

  • Platform: Editor(Linux)
  • Unity version: 6000.5.0b1

Checklist

  • This pull request is for merging into the develop branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@nnra6864
Copy link
Copy Markdown
Author

This still requires a lot of work, but I got rid of a significant amount of errors.
I am particularly stuck on this.
The new EntityId can only be converted to ulong, at least according to docs:
https://docs.unity3d.com/6000.5/Documentation/ScriptReference/EntityId.html

And Hash128 is too small for ulong.
I would really appreciate your suggestion.

This should work, but since we can't store full hashes, this has an
extremely small change of running into a duplicate hash, although the
odds are extremely small
@nnra6864
Copy link
Copy Markdown
Author

I actually managed to address the issue I mentioned above thanks to Chris Sophos from the Unity discord server.
The implementation does leave an extremely small chance of a duplicate hash happening, but it's highly unlikely.
There are no more errors reported after that last commit, just let me know if you'd like me to change something.

@nnra6864 nnra6864 marked this pull request as ready for review March 29, 2026 23:29
@nnra6864 nnra6864 requested a review from mob-sakai as a code owner March 29, 2026 23:29
@nnra6864 nnra6864 marked this pull request as draft March 31, 2026 22:42
@nnra6864 nnra6864 marked this pull request as ready for review March 31, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant