Repository navigation
Add "Enable Audio Ducking" checkbox - #1914
Conversation
This change mostly reverts a4be7ad Instead, it adds a checkbox to enable/disable the feature. When disabled, the ducking controls are disabled.
ddennedy
left a comment
ddennedy
left a comment
There was a problem hiding this comment.
Ugh, I just noticed that some field names are capitalized all words. Again, see our UI conventions.
I inclined to prefer this because the current approach with OFF and need to slide to turn it off is unconventional. However, as an additional row it looks awkwardly placed and redundant. How about a checkbox at the start of the heading?
☑️ Automatic Audio Ducking
You can ignore the build failures as Debian unstable being unstable.
Good catch! I don't know if I will ever get that right :(
Good idea. I kind of like that. 
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Threshold state synchronization and legacy shadow persistence issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (4)
What changed in this PR
Adds an opt-in audio-ducking checkbox, shadow threshold handling, undo support, and simplified spinner behavior.
Changes:
- Adds checkbox-controlled ducking UI and threshold synchronization.
- Adds duck-threshold undo/redo handling.
- Removes obsolete spinner override functionality.
| File | Summary |
|---|---|
src/widgets/trackpropertieswidget.ui |
Adds the ducking checkbox and updates threshold defaults. |
src/widgets/trackpropertieswidget.h |
Declares ducking state handlers. |
src/widgets/trackpropertieswidget.cpp |
Implements checkbox behavior and shadow values. Findings: two moderate issues involving zero-threshold state synchronization and legacy shadow persistence. |
src/widgets/doublesliderspinner.h |
Removes obsolete override properties. |
src/widgets/doublesliderspinner.cpp |
Simplifies spinner implementation. |
src/commands/timelinecommands.h |
Adds duck-threshold command declarations. |
src/commands/timelinecommands.cpp |
Implements threshold undo/redo behavior. Findings: one moderate legacy shadow fallback issue and one nit about missing debug logging. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Improve the synchronization of "threshold" and "enabled" since they share an underlying threshold property. Ensure that the shadow properties are always set by the constructor so there is no need for special handling of the properties being missing
This change mostly reverts a4be7ad
Instead, it adds a checkbox to enable/disable the feature. When disabled, the ducking controls are disabled.
Disabled:
Enabled:
I don't feel strongly about this change. But there were enough comments from the beta that I thought it was worth responding.