Repository navigation
avformat: fix segfault when reopening a file fails - #1341
Merged
ddennedy merged 1 commit intoOct 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
0 open findings
What changed in this PR
Fixes null dereferences when reopening media files fails in the avformat producer.
Changes:
- Preserves the original video context when reopening fails.
- Handles audio reopen failures safely.
- Prevents further setup after reopen errors.
| File | Description |
|---|---|
src/modules/avformat/producer_avformat.c |
Adds failure handling and cleanup guards for reopened contexts. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1335 by adding guards on second open.