Merged
Conversation
…-term support version of Node.js in our Dockerfile.
We want to have dependabot keep node up to date. The most straightforward way to do that is to separate out the building of js assets from the ruby app. That means the ruby image can't run node, but we don't need it to run the app. The js/css docker compose services need to use the assets target instead of the main web target.
niquerio
force-pushed
the
dockerfile-node-major-lts
branch
from
bcf1b38 to
8c6e33c
Compare
niquerio
changed the title
NODE_MAJOR to lts.
niquerio
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We want to have dependabot keep node up to date. The most straightforward way to do that is to separate out the building of js assets from the ruby app. That means the ruby image can't run node, but we don't need it to run the app.
The js/css docker compose services need to use the assets target instead of the main web target.