Conversation
Coverage Report for ./packages/components/
File CoverageNo changed files found. |
ddb2f55 to
ca7bb02
Compare
12bbbf4 to
b7a7899
Compare
b7a7899 to
2d90501
Compare
Co-authored-by: mfal <4696750+mfal@users.noreply.github.com>
…ent' of github.com:mittwald/flow into 2437-how-to-customize-the-empty-view-of-the-list-component # Conflicts: # apps/docs/src/content/04-components/structure/list/overview.mdx
|
We must have closer look into the layout-shifts from the initial loading state to the empty/non-empty list view. |
🚀 Preview DeploymentPreview environments are ready:
Images:
|
…-the-empty-view-of-the-list-component # Conflicts: # packages/remote-react-components/src/tests/visual/__screenshots__/Button.browser.test.tsx/Button-with-avatar-firefox-darwin.png # packages/remote-react-components/src/tests/visual/__screenshots__/Button.browser.test.tsx/Button-with-avatar-webkit-darwin.png # packages/remote-react-components/src/tests/visual/__screenshots__/Link.browser.test.tsx/Link-edge-cases-firefox-darwin.png # packages/remote-react-components/src/tests/visual/__screenshots__/Link.browser.test.tsx/Link-edge-cases-webkit-darwin.png
🚀 Preview DeploymentPreview environments are ready:
Images:
|
In general, I think it’s a good decision to integrate the initial EmptyView directly into the list. In the past, we often saw cases where the EmptyView for initial empty states where no items exist yet was simply forgotten by developers, so this approach helps avoid that. However, in the mStudio context, it does not feel visually appropriate to display a disabled ListHeader above the EmptyView. Because of this, I would prefer switching to a loading spinner during the initial loading state. A layout shift during loading cannot really be avoided anyway, regardless of whether we use a skeleton or a spinner. Using a spinner also keeps the option open to transition directly to an IllustratedMessage (EmptyView) without disabling the ListHeader. Visually, moving from fewer elements to more elements feels more natural and comfortable for users than the opposite direction. |
No description provided.