Skip to content

Get unit testing working - #702

Merged
clemiller merged 7 commits into
betafrom
remove-old-dependency
Nov 24, 2025
Merged

clemiller merged 7 commits into
betafrom
remove-old-dependency

Conversation

@jondricek

Copy link
Copy Markdown
Contributor

Turns out, Karma was deprecated in 2023 (https://www.npmjs.com/package/karma) so this pull request moves the test framework over to vitest.

It also fixes (at least some) tests so they run again. They broke awhile back.

It also removes some dependencies that are no longer used, e.g. tslint

@jondricek jondricek changed the title Remove old dependencies Get unit testing working Oct 26, 2025
@jondricek

Copy link
Copy Markdown
Contributor Author

The core pattern for fixing these tests is:

  • Add provideHttpClient() for components that inject services needing HTTP
  • Add config inputs with proper interfaces before calling fixture.detectChanges()
  • Add Material dialog providers (MatDialogRef, MAT_DIALOG_DATA) for dialog components
  • Add ActivatedRoute mocks with snapshot.data for components using ActivatedRoute
  • Create proper config objects matching component interfaces

@jondricek
jondricek changed the base branch from main to beta November 14, 2025 21:06
@clemiller
clemiller merged commit 1add30a into beta Nov 24, 2025
2 checks passed
@clemiller
clemiller deleted the remove-old-dependency branch November 24, 2025 14:10
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.8.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

seansica pushed a commit that referenced this pull request Mar 19, 2026
…e-old-dependency

Get unit testing working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants