[WIP] Mitosheet - Column Cards#2344
Open
ngafar wants to merge 12 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 72742d1. Configure here.
| self.table(arg) | ||
| continue | ||
| content = _write_args_to_string(args, kwargs) | ||
| self._append_text(content) |
There was a problem hiding this comment.
st.write duplicates structured blocks
Medium Severity
In StreamlitCardRecorder.write, arguments that already produce a dataframe or table block are still serialized and appended as a plain text block, so cards can show the same data twice (formatted table/grid plus a raw dump).
Reviewed by Cursor Bugbot for commit 72742d1. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Adds the ability to create cards for a column. Cards provide an "at a glance" overview of the column, and quickly explore the data.
Testing
Right click on a column header, and look for the Create Card option. You have to provide a brief description of what the card should contain. Once created, you can click on a cell to see the card.
Note that sometimes the card creation fails. If you re-submit it should work.
Documentation
Yes
Note
High Risk
Runs LLM-generated Python via
exec/eval(restricted builtins but still arbitrary logic on sheet data) and expands persisted analysis state; explore view transpile uses a naivedfstring replace.Overview
Adds column cards: per-column “at-a-glance” summaries when you select a cell, plus optional explore links that open related filtered sheets.
Backend: New
column_cardsonState(serialized to the frontend ascolumnCards).get_card_templateuses the existing LLM stack to return Streamlit-style cardcodeandexploreview_codeentries;get_card_contentruns that code via aStreamlitCardRecorder(execwith a restricted__builtins__) and returns UI blocks.set_column_card/add_explore_viewsteps persist definitions and materialize explore views (evalonview_code, new sheet withDATAFRAME_SOURCE_EXPLORE). Card definitions can be plain code or JSON{code, explore}.Frontend (in repo, not fully in diff):
SelectionCardoverlay,CardsTaskpane, and extensivemito.cssfor card metrics/tables/alerts; wired throughMito.tsxand API types.Lifecycle:
column_cardsis cleared on sheet overwrite and popped on dataframe delete.Reviewed by Cursor Bugbot for commit 72742d1. Configure here.