Identify github action logs#2169
Open
aarondr77 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| UJ_USER_EMAIL, USER_JSON_DEFAULT) | ||
| from mito_ai.utils.telemetry_utils import identify | ||
| from mito_ai.utils.utils import is_running_test | ||
| from mito_ai.utils.utils import is_github_actions, is_running_test |
There was a problem hiding this comment.
Unused import is_github_actions in create.py
Low Severity
The function is_github_actions is imported from mito_ai.utils.utils but never used anywhere in create.py. The code at line 70 still uses is_running_test() to set the GITHUB_ACTION_ID, which applies to all CI environments rather than specifically GitHub Actions. This appears to be either an accidental import or an incomplete change where the condition was intended to be updated but wasn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Identify GitHub action logs
Testing
Please provide a list of the ways you can "access" or use the functionality. Please try and be exhaustive here, and make sure that you test everything you list.
Documentation
Note if any new documentation needs to addressed or reviewed.
Note
Medium Risk
Changes telemetry gating so analytics events are sent during GitHub Actions runs, which can affect data volume and CI behavior if environment detection is wrong. It’s limited to GitHub Actions via
GITHUB_ACTIONS=true, but still touches telemetry/analytics flow.Overview
Enables telemetry
identifyand eventtrackcalls to be emitted during GitHub Actions workflows (even though CI is treated as a test environment), while continuing to suppress telemetry for local pytest and non-GitHub CI.Adds
is_github_actions()env detection and updatestelemetry_utils.identify()andtelemetry_utils.log()conditionals accordingly; minor import/comment cleanup increate.pyto align CI handling messaging.Written by Cursor Bugbot for commit ab15100. This will update automatically on new commits. Configure here.