Dependencies updates, and better handling of hydrogens, stereochemistry, and aromaticity - #67
Conversation
…error handling and support for Ketcher-style hydrogen annotations
|
@Adafede thank you for the PR! I have added the test - not passing yet. |
|
(I will push another commit in a minute) |
… hydrogen repairs
|
Passing now 👍🏼 |
|
Commit caad15f cuts run time enormoulsy; test are now passing in ca 1 sec (was 35 secs before) |
|
@Adafede I will update some cleanup rules for ketcher and run the new version of |
|
Let me know if |
…used package entries
|
@Adafede removing R,S stereochemistry for reaction SMARTS seems to work nicely with echo $smarts_string | tr -d "@" |
|
@mmzdouc Think I finally got something slightly cleaner... |
|
@Adafede wow all entries are passing 🤩 |
|
I just made the new version return a warning about stereo mismatches, will help everyone fixing these, tell me if this fits what you expected! |
|
@Adafede great workaround - I like that! I have made some small adujstments to the error text. I would rather not allow people to skip the validation step and I replaced this statement with a shoutout for people to get in touch with the maintainers. |
|
@Adafede we should probably unpin the Python version? We are not bound by |
|
@Adafede I did a quick update of the |
|
@Adafede I fully replaced |
Hi @mmzdouc,
Hopefully this should fix mite-standard/mite_data#533
and the issue you mentioned in the Slack channel
Moreover, it superseeds #65.
I still want to update rdkit and manually fix entries as per #62 but will wait for your input before.