phase 12: bump submodules with CI fix + ensemble-manager TS fix#2
Merged
Conversation
…guration_input - Submodule graphql_engine bumped to ba3e3df - Migration 1771200016000 adds is_optional BOOLEAN NOT NULL DEFAULT FALSE - Rollback via down.sql DROP COLUMN - ETL files untouched (D-11, D-12 honored)
…put permissions - Submodule graphql_engine bumped to 2653623 - Both insert (user/anchor) and anonymous select list include is_optional - Matches PATTERNS.md modified entry spec exactly
…asura apply - 12-01-SUMMARY.md: documents Tasks 1-2 complete, Task 3 awaiting human apply - STATE.md: position updated to checkpoint:human-action - ROADMAP.md: 12-01 marked as in-progress (Tasks 1-2 committed)
…ed in dev cluster
…ptional propagation)
- Add 12-02-SUMMARY.md with task details and deviations - Update STATE.md: advance to plan 3, update progress to 93% - Update ROADMAP.md: mark 12-02 complete
- Task 1: is_optional in ModelIO interface + GraphQL fragments (60e6f2e) - Task 2 RED: failing tests for modelIOFromCatalogGQL (8f171c1) - Task 2 GREEN: adapter update + codegen types.ts (0e765b1)
…l input skip logic - TapisJobService.createJobFileInputsFromSeed skips optional inputs with no datasets bound - Three new unit tests covering all three branches - Test fixtures: appWithOptionalInput, appWithUnknownRequiredInput, modelWithOptionalInput
- SUMMARY.md documents skip-when-optional branch in TapisJobService - STATE.md advanced to plan 5, progress 98% - ROADMAP.md updated with plan 04 complete
…ge tag) submodule pointers
…ild-push-action and sanitized branch name
…w widened so feature-branch image builds) Mirrors ui CI fix (e0547dd). Branch gsd/phase-12-is-optional was previously unbuildable because ci.yml hardcoded refs/heads/main. New tag in ghcr: ghcr.io/mintproject/model-catalog-api:7109442c06a39f9fe2bbe152a21c41750dc464b4 helm-charts/dynamo-values.yaml (gitignored) updated to pin this SHA so dev cluster pulls the 12-02 junctionColumns code path.
…ts junction is_optional on GET)
…+ visual reverify
…s isOptional across lazy DSpec refetch)
…ts junction columns as scalar)
…adge in read mode)
… + aliased data_bindings TS cast) - Widens build-image-amd64 trigger from '*' to '**' so slashed feature branches actually publish docker images (mirrors ui e0547dd, mca 7109442). - Casts iterated thread_model.data_bindings to local shape so TS compiles; query aliases modelcatalog_dataset_specification as model_io but codegen schema type no longer carries the alias after 12-03 codegen update.
… SAFE_BRANCH tag) Widens hasura docker-publish trigger from '*' to '**' and tags image with sanitized branch (slash to dash) so slashed feature branches build (mirrors ui e0547dd, mca 7109442). Not pinned in dev dynamo-values.yaml so no helm bump needed.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps submodule pointers for
mint-ensemble-managerandgraphql_engineto pull in CI workflow fixes that allow slashed feature branches to actually publish docker images.mint-ensemble-manager→ef84ba3(CI branches glob**+ aliaseddata_bindingsTS cast). PR: feat(schema): add input can be optional on model configuration mint-ensemble-manager#114graphql_engine→32a7e11(CI branches glob**+ SAFE_BRANCH tag). PR: feat(schema): add input can be optional on model configuration graphql_engine#12Closes the trap surfaced during phase 12-05: feature branch pushes silently produced no docker image, so dev cluster kept running stale tags. Already fixed previously in ui e0547dd and model-catalog-api 7109442; this PR completes the fix on the remaining two submodules.
Phase 12-04 deployment
Bumping
ensemble_manager.image.tagtoef84ba3a...inhelm-charts/dynamo-values.yaml(gitignored local override) and runninghelm upgradedeploys the phase 12-04 TapisJobService skip-when-optional logic to dev for the first time.Test plan
gsd/phase-12-is-optionaloptional input with no datasets is skipped,optional input with datasets present is includedmintproject/ensemble-manager:ef84ba3a..., helm rev 58)server.jscontains theSkipping optional input ... — no datasets boundlog line (compiled-in skip path verified)Follow-ups
.planning/todos/done/2026-04-28-widen-ensemble-manager-graphql-engine-ci-branches.md.helm-charts/dynamo-values.yamlremains gitignored (per todo2026-04-26-secure-dynamo-values-yaml-secrets.md).