Feature request: add a way to see requests/response body when debugging client

[iTrooz]

When debugging MinIO behaviour, it would be nice to have a flag, maybe repeating --debug twice, to show HTTP requests/responses body. For example, when doing mcli ls miniotest/test --debug, I would like to see the XML sent by the client/sent back by the server

I can do that using mcli admin trace, which is useful but I need adequate permissions to do that, and it only works with MinIO servers

[toastsandwich]

mc admin trace does the same thing, why add it to other command again ?

[klauspost]

The code doesn't show bodies on successful error codes. That is by design.

You can fork and change that:

mc/cmd/client-s3-trace_v4.go

Lines 85 to 89 in 2676e50

	if resp.StatusCode != http.StatusOK &&
	resp.StatusCode != http.StatusPartialContent &&
	resp.StatusCode != http.StatusNoContent {
	respTrace, err = httputil.DumpResponse(resp, true)
	} else {

and

mc/cmd/client-s3-trace_v2.go

Lines 64 to 67 in d4b7b00

	if resp.StatusCode != http.StatusOK &&
	resp.StatusCode != http.StatusPartialContent &&
	resp.StatusCode != http.StatusNoContent {
	respTrace, err = httputil.DumpResponse(resp, true)

[iTrooz]

mc admin trace does the same thing, why add it to other command again ?

mc admin trace needs admin permission on the MinIO servers, which an user may not always have. Plus, this command will show all requests received by the server, no matter the client. I would like to show the body of the specific requests my client makes.

The code doesn't show bodies on successful error codes. That is by design.

Got it ! Would you accept a PR to add this behaviour ? I was thinking of specifying --debug twice in order to show the body all the time