This repository was archived by the owner on Jul 24, 2019. It is now read-only.
Bold / Italic / Strike / Underline buttons don't work correctly#76
Open
alanpca wants to merge 3 commits into
Open
Bold / Italic / Strike / Underline buttons don't work correctly#76alanpca wants to merge 3 commits into
alanpca wants to merge 3 commits into
Conversation
alanpca
commented
Jun 12, 2013
alanpca
commented
- Fixes Bold / Italic / Strike / Underline buttons don't work correctly #19
- Problem: addRange or removeAllRanges kills the browser command states.
- Store cache in commandCache
- Add updateCommandCache and restoreCommandCache methods
- Add support for command-with-arg buttons to be in an active state
- Update command cache when running execCommand
- Store and then update selected commands when selecting a toolbar button
- Create the command cache by looking up the buttons that are in the DOM, set the default value to false
* Fixes steveathon#19 * Problem: addRange or removeAllRanges kills the browser command states. * Store cache in commandCache * Add updateCommandCache and restoreCommandCache methods * Add support for command-with-arg buttons to be in an active state * Update command cache when running execCommand * Store and then update selected commands when selecting a toolbar button * Create the command cache by looking up the buttons that are in the DOM, set the default value to false
|
The cache doesn't work properly. See http://jsfiddle.net/mreq/6h8pw/1/ for an example. Try selecting a word and clicking bold and italic afterwards. The word is italic only as the boldness is somehow overriden. With the original file, the example works fine - http://jsfiddle.net/mreq/6h8pw/. Commenting out everything connected with caching fixes that. |
Author
|
Hey @mreq, seems to have to do with using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.