feat(cli): make quickstart catalog repository configurable via --catalog-repo flag#6364
feat(cli): make quickstart catalog repository configurable via --catalog-repo flag#6364sachin9058 wants to merge 3 commits intomindersec:mainfrom
Conversation
The way to do this is to Thinking about the amount of code and a desire to test it, we should probably put the clone and find directories code in |
Got it, that makes sense thanks! I’ve moved away from depending on #6357 and implemented the clone logic inline for now so the PR is self-contained. That said, I agree it would be better to structure this under Let me update the PR with that approach 👍 |
…quickstart from clone helper
evankanderson
left a comment
There was a problem hiding this comment.
Rather than just converting the existing rule loading, we should probably do something more extensive where we load a profile, ruletypes, and supporting datasources from one of the README enabled directories in minder-rules-and-profiles?
That way, we can include the description of what the profile will do in the guided setup.
|
@evankanderson That makes sense, I like that direction 👍 Right now I focused on keeping the existing quickstart behavior but sourcing the rule type and profile from the repo. Extending this to support README-based directories with profiles, rule types, and datasources would definitely make the flow more flexible and user-friendly. I can open a follow-up PR to explore that approach once this one is in, if that sounds good. |
Summary
Add a
--catalog-repoflag to thequickstartcommand to allow users to specify a custom repository for loading rule and profile catalogs.Previously, the catalog repository URL was hardcoded, limiting flexibility to the default Minder catalog. This change enables users to provide their own repository while preserving the existing default behavior.
If the flag is not provided, the quickstart flow continues to use the default Minder catalog repository.
Additionally, the help text has been improved to better describe the purpose and usage of the flag.
Testing
make lint-fix go test ./...go run ./cmd/cli quickstart --catalog-repo