feat: add request_changes action to PR comment alerts#6304
Open
DharunMR wants to merge 1 commit intomindersec:mainfrom
Open
feat: add request_changes action to PR comment alerts#6304DharunMR wants to merge 1 commit intomindersec:mainfrom
DharunMR wants to merge 1 commit intomindersec:mainfrom
Conversation
Signed-off-by: DharunMR <maddharun56@gmail.com>
|
coverage: 58.619% (+0.003%) from 58.616% — DharunMR:Block-binaries into mindersec:main |
Member
There was a problem hiding this comment.
I think there's a competing PR in #6262 which has a bit more functionality -- can we let that one play out first?
Contributor
Author
Just now seen that pr doing this , should i close this pr? |
Member
|
Feel free to comment / review encourage on that PR. If it doesn't merge, then we might come back to this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new action configuration to pull_request_comment alerts, allowing Minder to send a REQUEST_CHANGES event to GitHub to actively block PR merges when a rule fails.
Testing
Added unit tests to verify the configuration correctly triggers the REQUEST_CHANGES GitHub API event while preserving backward compatibility for the default COMMENT behavior.