Skip to content

enhance: bump knowhere to v3.0.8 - #52631

Closed
foxspy wants to merge 1 commit into
milvus-io:3.0from
foxspy:update-knowhere-v3.0.8
Closed

enhance: bump knowhere to v3.0.8#52631
foxspy wants to merge 1 commit into
milvus-io:3.0from
foxspy:update-knowhere-v3.0.8

Conversation

@foxspy

@foxspy foxspy commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Move the knowhere pin from 6a3b7df1 to the v3.0.8 tag (main at d85f7080, zilliztech/knowhere#1780), which bumps the cardinal references to v3.0.5 (v2) and v2.5.110 (v1).

The stale comment above the pin is updated to describe the new one.

Heads-up for reviewers: this range also brings in zilliztech/knowhere#1673 "support nullable external id mapping", which the previous pin deliberately excluded.

Move the knowhere pin from 6a3b7df1 to the v3.0.8 tag (main at
d85f7080, zilliztech/knowhere#1780), which bumps the cardinal
references to v3.0.5 (v2) and v2.5.110 (v1).

Note this range also brings in milvus-io#1673 "support nullable external id
mapping", which the previous pin deliberately excluded.

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@sre-ci-robot sre-ci-robot added area/compilation size/XS Denotes a PR that changes 0-9 lines. labels Aug 18, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zhengbuqian after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhengbuqian in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify Bot added the dco-passed DCO check passed. label Aug 18, 2026
@mergify

mergify Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

@foxspy Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

@mergify mergify Bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Aug 18, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: ci-v2 system is enabled for this PR (3.0 branch).

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests)
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e tests)
  • /ci-rerun-e2e-amd-gray // for ci-v2/e2e-amd-gray (TC pool shadow; non-gating)
  • /ci-rerun-e2e-dist-wp // for ci-v2/e2e-dist-wp (Tencent distributed woodpecker-service boundary)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests)
  • /ci-rerun-gosdk-std // for ci-v2/go-sdk-std (Go SDK E2E, standalone)
  • /ci-rerun-gosdk-dist-wp // for ci-v2/go-sdk-dist-wp (distributed + Woodpecker service)

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot

Copy link
Copy Markdown
Contributor

❌ CI Loop Results d5db8fa

Stage Result Duration Tests
✅ Build SUCCESS 15.9min -
✅ Code-Check SUCCESS 11.6min -
✅ UT-Integration SUCCESS 25.1min -
✅ UT-GO SUCCESS 22.3min -
❌ UT-CPP-Cov FAILURE 56.8min 8588 total, 8587 passed, 1 failed

Total: 79min | Pipeline | Artifacts
Diff Coverage: CPP 84.8% (434 hit, 78 miss, 512 measurable lines, 796 unmeasured)
Total Patch Coverage: 84.8% (434/512 measurable lines, 796 unmeasured)

Failed Test Logs:

@foxspy

foxspy commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Closing: superseded, and merging it now would be a regression.

master and 3.0 both already pin knowhere d7cfd888, not the 6a3b7df1 this PR was written against. The pin moved twice since:

So this PR's intent — get onto a knowhere revision carrying cardinal v3.0.5 / v2.5.110 — is already satisfied, and d85f7080 is now 3 commits behind the current pin. Merging would drop:

The concern in the original description — that this bump re-introduces zilliztech/knowhere#1673 — is also moot: 7cc9d4be is already an ancestor of the current pin (0 behind / 15 ahead).

If a tag-form pin is still wanted for the 3.0 branch, it should be a fresh tag cut at d7cfd888 or later, not v3.0.8 (= d85f7080).

@foxspy foxspy closed this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compilation dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants