enhance: bump knowhere to v3.0.8 - #52631
Conversation
Move the knowhere pin from 6a3b7df1 to the v3.0.8 tag (main at d85f7080, zilliztech/knowhere#1780), which bumps the cardinal references to v3.0.5 (v2) and v2.5.110 (v1). Note this range also brings in milvus-io#1673 "support nullable external id mapping", which the previous pin deliberately excluded. Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@foxspy Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #") |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
❌ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 15.9min | - |
| ✅ Code-Check | SUCCESS | 11.6min | - |
| ✅ UT-Integration | SUCCESS | 25.1min | - |
| ✅ UT-GO | SUCCESS | 22.3min | - |
| ❌ UT-CPP-Cov | FAILURE | 56.8min | 8588 total, 8587 passed, 1 failed |
Total: 79min | Pipeline | Artifacts
Diff Coverage: CPP 84.8% (434 hit, 78 miss, 512 measurable lines, 796 unmeasured)
Total Patch Coverage: 84.8% (434/512 measurable lines, 796 unmeasured)
Failed Test Logs:
- UT-CPP-Cov: view log
|
Closing: superseded, and merging it now would be a regression. master and 3.0 both already pin knowhere
So this PR's intent — get onto a knowhere revision carrying cardinal v3.0.5 / v2.5.110 — is already satisfied, and
The concern in the original description — that this bump re-introduces zilliztech/knowhere#1673 — is also moot: If a tag-form pin is still wanted for the 3.0 branch, it should be a fresh tag cut at |
Move the knowhere pin from
6a3b7df1to thev3.0.8tag (main atd85f7080, zilliztech/knowhere#1780), which bumps the cardinal references to v3.0.5 (v2) and v2.5.110 (v1).The stale comment above the pin is updated to describe the new one.
Heads-up for reviewers: this range also brings in zilliztech/knowhere#1673 "support nullable external id mapping", which the previous pin deliberately excluded.