windows-bindgen: Intrinsify WIN32_ERROR, NTSTATUS and RPC_STATUS#4399
Closed
sylveon wants to merge 2 commits intomicrosoft:masterfrom
Closed
windows-bindgen: Intrinsify WIN32_ERROR, NTSTATUS and RPC_STATUS#4399sylveon wants to merge 2 commits intomicrosoft:masterfrom
sylveon wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Collaborator
Author
|
Looks like it fails to generate bindings when explicitly referring to a specific value of these error codes (failing to generate the type itself is expected, as it currently does with |
Collaborator
Author
|
Closing in favor of #4401 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4392 by making windows-bindgen explicitly aware of these types, and handling them exactly like
HRESULTcurrently is handled.