Fix Administrator label missing in command center#309255
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix Administrator label missing in command center#309255yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The AgentTitleBarStatusWidget creates its own WindowTitle instance to render the command center label, but this instance never received the isAdmin/isPure property updates that flow through the title service. As a result, getTitleDecorations() always returned an empty suffix, and the [Administrator] label was never shown in the agent status pill that replaces the default command center. Fix by exposing titleProperties and onDidChangeTitleProperties on the ITitlebarPart interface, then syncing properties from the title service to the widget's WindowTitle instance. Fixes microsoft#308595
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Administrator]label stopped appearing in the command center search bar because theAgentTitleBarStatusWidget(which replaces the default command center in compact/agent mode) creates its ownWindowTitleinstance that never receives theisAdmin/isPureproperty updates flowing through the title servicetitlePropertiesandonDidChangeTitlePropertieson theITitlebarPartinterface, then sync these properties from the title service into the widget'sWindowTitlesogetTitleDecorations()returns the correct[Administrator]suffixFixes #308595
Test plan
[Administrator]label appears in the command center search bar with default settings (agent status compact mode)[Administrator]label appears when agent status is in non-compact mode[Administrator]label appears in the plain text title bar when command center is disabled[Superuser]label appears when running as root