Skip to content

Keybindings Editor - add column header sorting#309254

Open
thevrus wants to merge 1 commit intomicrosoft:mainfrom
thevrus:thevrus/keybindings-editor-column-sorting
Open

Keybindings Editor - add column header sorting#309254
thevrus wants to merge 1 commit intomicrosoft:mainfrom
thevrus:thevrus/keybindings-editor-column-sorting

Conversation

@thevrus
Copy link
Copy Markdown

@thevrus thevrus commented Apr 12, 2026

Adds click-to-sort on column headers in the Keyboard Shortcuts editor.

Changes

  • Extends the base Table widget with onDidClickColumn event and setSortColumn() API
  • All data columns (Command, Keybinding, When, Source) cycle through ascending → descending → default on click
  • Sort indicator arrow and aria-sort attribute on the active column header

How to test

  1. Open Keyboard Shortcuts (Cmd+K Cmd+S)
  2. Click any column header (Command, Keybinding, When, Source)
  3. First click sorts ascending (up arrow), second click descending (down arrow), third click resets
  4. Verify sort works together with the "Sort by Precedence" toggle and search filtering

@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@joaomoreno

Matched files:

  • src/vs/base/browser/ui/table/table.css
  • src/vs/base/browser/ui/table/table.ts
  • src/vs/base/browser/ui/table/tableWidget.ts

@benibenj

Matched files:

  • src/vs/base/browser/ui/table/table.css
  • src/vs/base/browser/ui/table/table.ts
  • src/vs/base/browser/ui/table/tableWidget.ts

@rzhao271

Matched files:

  • src/vs/workbench/contrib/preferences/browser/keybindingsEditor.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants