Fix editor sticky scroll shadow missing#309253
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix editor sticky scroll shadow missing#309253yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The editor sticky scroll's bottom shadow was not rendering reliably. The previous approach used a box-shadow directly on the widget's root element which also had overflow:hidden, causing the outward shadow to be clipped. This adopts the same proven pattern used by the tree view's sticky scroll: a dedicated shadow element positioned just below the content area, using an inset box-shadow that is never clipped by the parent's overflow. The widget's DOM is restructured with a content wrapper (sticky-widget-content) that carries the overflow:hidden and border, while the outer root (sticky-widget) allows the shadow element to extend beyond the content bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #300355
The editor sticky scroll's bottom shadow was not rendering because the outward
box-shadowon the widget root was clipped by its ownoverflow: hidden.This restructures the sticky scroll widget DOM to match the proven pattern used by the tree view's sticky scroll:
sticky-widget-content(new inner wrapper): carriesoverflow: hiddenand the bottom border, containing the line numbers and line contentsticky-widget-shadow(new element): positioned just below the content area with aninsetbox-shadow that renders reliably regardless of parent overflowsticky-widget(root): no longer hasoverflow: hidden, allowing the shadow element to extend beyond the content boundsTest plan