git: always show clone destination picker when cached repo exists#309247
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
git: always show clone destination picker when cached repo exists#309247yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When a repository URL had exactly one cached clone location, tryOpenExistingRepository() bypassed the quick pick prompt and directly used that cached path. The user was never shown the dialog with the "Clone again" option, so they could not choose a new destination folder. Always route through chooseExistingRepository() regardless of the number of cached entries. Fixes microsoft#307824
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running Git: Clone and the repository URL had exactly one cached clone location,
tryOpenExistingRepository()bypassed the quick pick prompt and directly used that cached path. The user was never shown the "Open Existing Repository Clone" dialog with the "Clone again" option, so they could not choose a new destination folder.Root cause
In
cloneManager.ts, whenexistingCachedRepositories.length === 1, the code short-circuited directly to the cached workspace path without callingchooseExistingRepository().Fix
Always route through
chooseExistingRepository()regardless of the number of cached entries, so the user can pick the existing clone or opt to clone again into a different folder.Fixes #307824