Skip to content

fix: use DI for vscode API in nodeLauncher instead of direct import #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connor4312 merged 2 commits into from
Jun 3, 2026
+5 −3
Merged

fix: use DI for vscode API in nodeLauncher instead of direct import #2369

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09fd5a9
fix: use DI for vscode API in nodeLauncher instead of direct import
lucygramley Jun 3, 2026
83dbd3c
Update src/targets/node/nodeLauncher.ts
lucygramley Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/targets/node/nodeLauncher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
* Copyright (C) Microsoft Corporation. All rights reserved.
*--------------------------------------------------------*/

import { inject, injectable, multiInject } from 'inversify';
import { inject, injectable, multiInject, optional } from 'inversify';
import { extname, resolve } from 'path';
import * as vscode from 'vscode';
import type * as vscodeType from 'vscode';
import { IBreakpointsPredictor } from '../../adapter/breakpointPredictor';
import { IPortLeaseTracker } from '../../adapter/portLeaseTracker';
import Cdp from '../../cdp/api';
Expand All @@ -16,6 +16,7 @@ import { fixDriveLetterAndSlashes } from '../../common/pathUtils';
import { delay } from '../../common/promiseUtil';
import { absolutePathToFileUrl, urlToRegex } from '../../common/urlUtils';
import { AnyLaunchConfiguration, INodeLaunchConfiguration } from '../../configuration';
import { VSCodeApi } from '../../ioc-extras';
import { fixInspectFlags } from '../../ui/configurationUtils';
import { retryGetNodeEndpoint } from '../browser/spawn/endpoints';
import { ISourcePathResolverFactory } from '../sourcePathResolverFactory';
Expand Down Expand Up @@ -77,6 +78,7 @@ export class NodeLauncher extends NodeLauncherBase<INodeLaunchConfiguration> {
@inject(IPackageJsonProvider) private readonly packageJson: IPackageJsonProvider,
@inject(ISourcePathResolverFactory) pathResolverFactory: ISourcePathResolverFactory,
@inject(IPortLeaseTracker) portLeaseTracker: IPortLeaseTracker,
@optional() @inject(VSCodeApi) private readonly vscode?: typeof vscodeType,
) {
super(pathProvider, logger, portLeaseTracker, pathResolverFactory);
}
Expand Down Expand Up @@ -313,7 +315,11 @@ export class NodeLauncher extends NodeLauncherBase<INodeLaunchConfiguration> {
return targetProgram;
}

const resolve = readConfig(vscode.workspace, Configuration.ResolveDebugEntrypoint);
if (!this.vscode) {
return targetProgram;
}

const resolve = readConfig(this.vscode.workspace, Configuration.ResolveDebugEntrypoint);
Comment thread
lucygramley marked this conversation as resolved.
Outdated
if (!resolve) {
return targetProgram;
}
Expand Down
Loading