Skip to content

Fix FTP explorer subdirectory file retrieval (#1155)#1290

Open
fhwvtqdc2q-svg wants to merge 1 commit into
microsoft:mainfrom
fhwvtqdc2q-svg:fix/tree-view-ftp-subdirectory-1155
Open

Fix FTP explorer subdirectory file retrieval (#1155)#1290
fhwvtqdc2q-svg wants to merge 1 commit into
microsoft:mainfrom
fhwvtqdc2q-svg:fix/tree-view-ftp-subdirectory-1155

Conversation

@fhwvtqdc2q-svg

Copy link
Copy Markdown
Contributor

Summary

  • Build root FTP URIs with //\ instead of ///\ so paths stay well-formed
  • Preserve the \ tp\ scheme when creating child URIs via
    esource.with()\ instead of \Uri.parse(fsPath)\
  • Use \substr(1)\ in \getContent\ so nested paths like /pub/example/readme.txt\ resolve correctly
  • Switch the demo FTP server to \ est.rebex.net\ because \mirror.switch.ch\ is no longer available

Fixes #1155

Test plan


  • pm run compile\ in \ ree-view-sample\
  • Press F5 in \ ree-view-sample, open FTP Explorer, navigate to /pub/example, and open
    eadme.txt\

Made with Cursor

- Build root URIs with // instead of /// so paths stay well-formed
- Preserve ftp scheme when creating child URIs via resource.with()
- Use substr(1) in getContent so nested paths resolve correctly
- Switch demo server to test.rebex.net (mirror.switch.ch is unavailable)

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ftpExplorer in tree-view-sample can only retrieve top level files

1 participant