Skip to content

allow telemetry here #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffj6123 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow telemetry here #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9291aa
allow telemetry here
jeffj6123 Sep 10, 2021
b6700af
Merge branch 'master' into update-telem
jeffj6123 Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Pre Test configuration
run: |
python scripts/check_and_use_custom_sdk.py
sfctl settings telemetry set-telemetry --off
# sfctl settings telemetry set-telemetry --off

@samedder samedder Sep 10, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

- name: test
run: |
scripts/verify.sh local
2 changes: 1 addition & 1 deletion src/sfctl/helps/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
helps[''] = """
type: group
short-summary: Commands for managing Service Fabric clusters
and entities. This version is compatible with Service Fabric 7.1
and entities. This version is compatible with Service Fabric 8.1
runtime.
long-summary: Commands follow the noun-verb pattern. See subgroups for more
information.
Expand Down
2 changes: 1 addition & 1 deletion src/sfctl/send_telemetry_background.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from sfctl.telemetry import TELEMETRY_FILE_PATH
from sfctl.state import set_telemetry_send_retry_count

INSTRUMENTATION = '482faeea-c22b-4c75-a1af-5bfe79f36cb7'
INSTRUMENTATION = 'bcc8168f-be0f-4622-8fe7-b930d173b8a9'
SINGLE_UPLOAD_TIMEOUT = 30

def read_telemetry_entries():
Expand Down