fix(analyzer): prevent metaclass base members from leaking onto class instances - #11690
Open
Henry Su (hsusul) wants to merge 1 commit into
Open
fix(analyzer): prevent metaclass base members from leaking onto class instances#11690Henry Su (hsusul) wants to merge 1 commit into
Henry Su (hsusul) wants to merge 1 commit into
Conversation
… instances Class instances with custom metaclasses should not inherit members from 'type' (such as type.__dict__ with MappingProxyType). Metaclass base classes like 'type' should be skipped when resolving members on class instances.
Member
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
Member
|
Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Result: Summary: Verification could not run because no trusted sandbox image is configured for `microsoft/pyright`, and local execution was not authorized. The PR adds one targeted `Metaclass12` regression test covering instance and class metaclass-member resolution. No test result is available, so confidence is limited. Test runs: 1 not run
|
Bill Schnurr (bschnurr)
approved these changes
Aug 31, 2026
Bill Schnurr (bschnurr)
left a comment
Member
There was a problem hiding this comment.
Approved via Review Center.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11548.
Summary of Changes
typeUtils.ts:getClassIteratorso thatSkipTypeBaseClassandSkipObjectBaseClasschecks useisClass(specializedMroClass)(enabling them to apply when traversing class instances as well as instantiables).lookUpClassMember, forwardedSkipTypeBaseClasswhen searching metaclass for class instances (isClassInstance(classType)).typeEvaluator.ts:getTypeOfClassMemberName, includedMemberAccessFlags.SkipBaseClassesalongsideSkipTypeBaseClass.metaclass12.pyand test suite entry intypeEvaluator1.test.tsverifying that:a.__dict__on an instancea: A(whereclass A(metaclass=Meta)) resolves todict[str, Any].a.meta_method()generates an attribute error.A.__dict__andA.meta_method()continues to resolve via the metaclass.